fix(colors): convert rgba/hsla to rgb/hsl if opacity is >= 1 #1083
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1082
Fixes:
rgba(R,G,B,1)
=>rgb(R,G,B)
rgb(R,G,B,1)
=>rgb(R,G,B)
hsla(H,S,L,1)
=>hsl(H,S,L)
hsl(H,S,L,1)
=>hsl(H,S,L)
rgb
,rgba
,hsl
, andhsla
For reference, CSS 4 supports alpha parameter for
rgb()
andhsl()
. That's why the new regex is also optionally looking fora
. If it finds it and opacity is 1, then it effectively removes the alpha parameter. That's a plus for backwards compatibility for browsers that don't supportrgb(R G B A)
.https://developer.mozilla.org/en-US/docs/Web/CSS/color_value