Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

cc-check should only warn if "unrestricted_guest" is not set when running under a hypervisor #439

Closed
jodh-intel opened this issue Aug 21, 2017 · 1 comment
Assignees

Comments

@jodh-intel
Copy link
Contributor

Now that virtcontainers provides a way to detect if running under a hypervisor...

... we need to update cc-check to determine more intelligently if the environment is capable of running a Clear Container since although environments like Azure do not provide unrestricted_guest, it is still possible to run a Clear Container on it.

In summary, cc-check needs to do the following:

  • if running under a hypervisor, only warn if unrestricted_guest is not set (since it does work under Azure for example).
  • If not running under a hypervisor, error if unrestricted_guest is not set (no change to current behaviour).

See comments on #422.

@sboeuf
Copy link
Contributor

sboeuf commented Aug 21, 2017

👍

@jodh-intel jodh-intel self-assigned this Aug 21, 2017
jodh-intel added a commit to jodh-intel/runtime that referenced this issue Aug 21, 2017
If running under a hypervisor, the kvm "unrestricted_guest" option is
not required.

Fixes clearcontainers#439.

Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel added a commit to jodh-intel/runtime that referenced this issue Aug 21, 2017
If running under a hypervisor, the kvm "unrestricted_guest" option is
not required.

Fixes clearcontainers#439.

Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel added a commit to jodh-intel/runtime that referenced this issue Aug 21, 2017
If running under a hypervisor, the kvm "unrestricted_guest" option
is not required.

Fixes clearcontainers#439.

Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel added a commit to jodh-intel/runtime that referenced this issue Aug 22, 2017
If running under a hypervisor, the kvm "unrestricted_guest" option
is not required.

Fixes clearcontainers#439.

Signed-off-by: James O. D. Hunt <[email protected]>
mcastelino pushed a commit to mcastelino/runtime that referenced this issue Dec 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants