Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

makefile: Allow for kata build #919

Closed
sboeuf opened this issue Jan 12, 2018 · 3 comments
Closed

makefile: Allow for kata build #919

sboeuf opened this issue Jan 12, 2018 · 3 comments
Assignees
@jodh-intel

Comments

@sboeuf
Copy link
Contributor

sboeuf commented Jan 12, 2018

I think we should add the possibility to generate everything for a kata-runtime binary from the Makefile. We would use make kata in order to generate everything we need.
@jodh-intel
Copy link
Contributor

Related: #920, #921.

@jodh-intel
Copy link
Contributor

I agree in principle, but it should probably be as follows for consistency with what we have already:

# build for Clear Containers (already exists)
make build-cc-system  && sudo make install-cc-system

# build for Kata Containers (TODO :)
make build-kata-system  && sudo make install-kata-system

@jodh-intel jodh-intel self-assigned this Jan 16, 2018
@sboeuf
Copy link
Contributor Author

sboeuf commented Jan 16, 2018

@jodh-intel I agree, but I didn't want to introduce too much changes for our current CC case. But for consistency, not using only make for CC would be better.

jodh-intel added a commit to jodh-intel/runtime that referenced this issue Jan 17, 2018
@jodh-intel
build: Allow for kata project build
f63d5d2 
Rework the build system to allow the runtime to be built for either of
the following:

- Clear Containers (`cc-runtime` binary and configuration)
- Kata Containers (`kata-runtime` binary and configuration)

The existing build rules are retained but there are now two new rules:

  $ make build-kata-system
  $ sudo make install-kata-system

Two new variables have also been added:

- KATA_SYSTEM_BUILD: set to any value to build/install for Kata.
- SYSTEM_BUILD_TYPE: build for either Clear Containers (set to `cc`) or
  Kata (set to `kata`).

See "make help" for further details.

Note that configuration files are installed to a project-specific
directory, allowing for systems to be installed for both Kata and Clear
Containers.

Finally, the bash completion and collection scripts have been updated
to work for either project.

Fixes clearcontainers#919, clearcontainers#921.

Signed-off-by: James O. D. Hunt <[email protected]>
@jodh-intel jodh-intel mentioned this issue Jan 17, 2018
Merged
jodh-intel added a commit to jodh-intel/runtime that referenced this issue Jan 17, 2018
@jodh-intel
build: Allow for kata project build
71ff845 
Rework the build system to allow the runtime to be built for either of
the following:

- Clear Containers (`cc-runtime` binary and configuration)
- Kata Containers (`kata-runtime` binary and configuration)

The existing build rules are retained but there are now two new rules:

  $ make build-kata-system
  $ sudo make install-kata-system

Two new variables have also been added:

- KATA_SYSTEM_BUILD: set to any value to build/install for Kata.
- SYSTEM_BUILD_TYPE: build for either Clear Containers (set to `cc`) or
  Kata (set to `kata`).

See "make help" for further details.

Note that configuration files are installed to a project-specific
directory, allowing for systems to be installed for both Kata and Clear
Containers.

Finally, the bash completion and collection scripts have been updated
to work for either project.

Fixes clearcontainers#919, clearcontainers#921.

Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel added a commit to jodh-intel/runtime that referenced this issue Jan 17, 2018
@jodh-intel
build: Allow for kata project build
8be1ed7 
Rework the build system to allow the runtime to be built for either
of the following:

- Clear Containers (`cc-runtime` binary and configuration)
- Kata Containers (`kata-runtime` binary and configuration)

The existing build rules are retained but there are now two new rules:

```
$ make build-kata-system
$ sudo make install-kata-system
```

Two new variables have also been added:

- `KATA_SYSTEM_BUILD`: set to any value to build/install for Kata.
- `SYSTEM_BUILD_TYPE`: build for either Clear Containers (set to `cc`) or
  Kata (set to `kata`).

See `make help` for further details.

Note that configuration files are installed to a project-specific
directory, allowing for systems to be installed for both Kata and Clear
Containers.

Finally, the bash completion and collection scripts have been updated
to work for either project.

Fixes clearcontainers#919, clearcontainers#921.

Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel added a commit to jodh-intel/runtime that referenced this issue Jan 17, 2018
@jodh-intel
build: Allow for kata project build
f5c282c 
Rework the build system to allow the runtime to be built for either
of the following:

- Clear Containers (`cc-runtime` binary and configuration)
- Kata Containers (`kata-runtime` binary and configuration)

The existing build rules are retained but there are now two new rules:

```
$ make build-kata-system
$ sudo make install-kata-system
```

Two new variables have also been added:

- `KATA_SYSTEM_BUILD`: set to any value to build/install for Kata.
- `SYSTEM_BUILD_TYPE`: build for either Clear Containers (set to `cc`) or
  Kata (set to `kata`).

See `make help` for further details.

Note that configuration files are installed to a project-specific
directory, allowing for systems to be installed for both Kata and Clear
Containers.

Finally, the bash completion and collection scripts have been updated
to work for either project.

Fixes clearcontainers#919, clearcontainers#921.

Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel added a commit to jodh-intel/runtime that referenced this issue Jan 18, 2018
@jodh-intel
build: Allow for kata project build
6cc2899 
Rework the build system to allow the runtime to be built for either
of the following:

- Clear Containers (`cc-runtime` binary and configuration)
- Kata Containers (`kata-runtime` binary and configuration)

The existing build rules are retained but there are now two new rules:

```
$ make build-kata-system
$ sudo make install-kata-system
```

Two new variables have also been added:

- `KATA_SYSTEM_BUILD`: set to any value to build/install for Kata.
- `SYSTEM_BUILD_TYPE`: build for either Clear Containers (set to `cc`) or
  Kata (set to `kata`).

See `make help` for further details.

Note that configuration files are installed to a project-specific
directory, allowing for systems to be installed for both Kata and Clear
Containers.

Finally, the bash completion and collection scripts have been updated
to work for either project.

Fixes clearcontainers#919, clearcontainers#921.

Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel added a commit to jodh-intel/runtime that referenced this issue Jan 18, 2018
@jodh-intel
build: Allow for kata project build
4898b84 
Rework the build system to allow the runtime to be built for either
of the following:

- Clear Containers (`cc-runtime` binary and configuration)
- Kata Containers (`kata-runtime` binary and configuration)

The existing build rules are retained but there are now two new rules:

```
$ make build-kata-system
$ sudo make install-kata-system
```

Two new variables have also been added:

- `KATA_SYSTEM_BUILD`: set to any value to build/install for Kata.
- `SYSTEM_BUILD_TYPE`: build for either Clear Containers (set to `cc`) or
  Kata (set to `kata`).

See `make help` for further details.

Note that configuration files are installed to a project-specific
directory, allowing for systems to be installed for both Kata and Clear
Containers.

Finally, the bash completion and collection scripts have been updated
to work for either project.

Fixes clearcontainers#919, clearcontainers#921.

Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel added a commit to jodh-intel/runtime that referenced this issue Jan 18, 2018
@jodh-intel
build: Allow for kata project build
7a9a492 
Rework the build system to allow the runtime to be built for either
of the following:

- Clear Containers (`cc-runtime` binary and configuration)
- Kata Containers (`kata-runtime` binary and configuration)

The existing build rules are retained but there are now two new rules:

```
$ make build-kata-system
$ sudo make install-kata-system
```

Two new variables have also been added:

- `KATA_SYSTEM_BUILD`: set to any value to build/install for Kata.
- `SYSTEM_BUILD_TYPE`: build for either Clear Containers (set to `cc`) or
  Kata (set to `kata`).

See `make help` for further details.

Note that configuration files are installed to a project-specific
directory, allowing for systems to be installed for both Kata and Clear
Containers.

Finally, the bash completion and collection scripts have been updated
to work for either project.

Fixes clearcontainers#919, clearcontainers#921.

Signed-off-by: James O. D. Hunt <[email protected]>
mcastelino pushed a commit to mcastelino/runtime that referenced this issue Dec 6, 2018
@Ace-Tang
virtcontainers: fix not close socket with ethtool
4b9a471 
close socket after use ethtool.NewEthtool()

Fixes: clearcontainers#919

Signed-off-by: Ace-Tang <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jodh-intel jodh-intel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jodh-intel @sboeuf