This repository has been archived by the owner on May 6, 2020. It is now read-only.
scripts: Make Collect script consider log levels #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proxy no longer runs as a systemd service so remove the systemd unit selector code. Signed-off-by: James O. D. Hunt <[email protected]>
Added extra patterns to the collect script to extract specific logs records at specific log levels; an error log entry is always an error, regardless of whether it's message text matches any of the other heuristic patterns. Fixes clearcontainers#1049. Signed-off-by: James O. D. Hunt <[email protected]>
Show the available options when displaying the collect scripts usage message. Signed-off-by: James O. D. Hunt <[email protected]>
Added the ability to query the collect script version before running it. Signed-off-by: James O. D. Hunt <[email protected]>
grahamwhaley
approved these changes
Mar 7, 2018
| @@ -85,6 +85,10 @@ Description: Run this script as root to obtain a markdown-formatted summary | |||
|
|
|||
| $issue_url | |||
|
|
|||
| Options: | |||
|
|
|||
| -h | --help | help : show this usage summary. | |||
data/collect-data.sh.in
Outdated
| @@ -88,10 +88,18 @@ Description: Run this script as root to obtain a markdown-formatted summary | |||
| Options: | |||
|
|
|||
| -h | --help | help : show this usage summary. | |||
| -v | --version | version : show program version. | |||
There was a problem hiding this comment.
ah, and there we go...
|
re-triggering jenkins-ci-fedora-26
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added extra patterns to the collect script to extract specific logs
records at specific log levels; an error log entry is always an error,
regardless of whether it's message text matches any of the other
heuristic patterns.
Fixes #1049.
Signed-off-by: James O. D. Hunt [email protected]