This repository has been archived by the owner on May 6, 2020. It is now read-only.
docs: Add link to install guides in README #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note the link to the docs directory. We could create a nicely-formatted list of installation guides in the README, but that's more maintenance. We could also have the README link to the wiki, but since the wiki links back to the repo, that seems a bit odd circuitous ;) |
|
Popular Images qa-passed 👍 |
|
Hi @iphutch - please can you review? |
iphutch
reviewed
Sep 12, 2017
README.md
Outdated
| @@ -33,6 +33,10 @@ The runtime has a built-in command to determine if your host system is capable o | |||
| $ cc-runtime cc-check | |||
| ``` | |||
|
|
|||
| ## Quick start for users | |||
|
|
|||
| See the installation guides available for various operating systems [here](docs/). | |||
There was a problem hiding this comment.
So that we can avoid "here", lets move the link to "installation guides" as has been done in the two sections following this one:
See the installation guides available for various operating systems.
jodh-intel
force-pushed
the
add-link-to-install-docs
branch
from
200faf7
to
71c4a11
Compare
|
Popular Images qa-passed 👍 |
jodh-intel
force-pushed
the
add-link-to-install-docs
branch
from
71c4a11
to
35acce1
Compare
|
@iphutch and approvers - please can you review? |
|
Popular Images qa-passed 👍 |
jodh-intel
force-pushed
the
add-link-to-install-docs
branch
from
35acce1
to
840ebb7
Compare
|
Popular Images qa-passed 👍 |
jodh-intel
force-pushed
the
add-link-to-install-docs
branch
from
840ebb7
to
5267182
Compare
Although the wiki includes links to the installation guides, so should the README. Fixes clearcontainers#537. Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel
force-pushed
the
add-link-to-install-docs
branch
from
5267182
to
b0e8112
Compare
mcastelino
pushed a commit
to mcastelino/runtime
that referenced
this pull request
Dec 6, 2018
So that shared memory guests can still generate different random numbers. Fixes: clearcontainers#538 Signed-off-by: Peng Tao <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the wiki includes links to the installation guides,
so should the README.
Fixes #537.
Signed-off-by: James O. D. Hunt [email protected]