This repository has been archived by the owner on May 6, 2020. It is now read-only.
cc env add hypervisor version #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a new makeVersionBinary() function to allow makeRuntimeConfig() to be simplified. Signed-off-by: James O. D. Hunt <[email protected]>
The "cc-env" command now displays the hypervisor version for parity with the other components. Fixes clearcontainers#500. Signed-off-by: James O. D. Hunt <[email protected]>
|
Popular Images qa-passed 👍 |
|
Note that although this could be construed as a new feature, it would be super-useful if the output of |
|
lgtm |
|
@devimc, @grahamwhaley, @sameo - could you review? |
mcastelino
pushed a commit
to mcastelino/runtime
that referenced
this pull request
Dec 6, 2018
Right now we create it in `createsandbox` and it would create the vm dir unnecessarily for fetchsandbox() and it ends up leaving an empty vm dir behind even after DeleteSandbox. Fixes: clearcontainers#547 Signed-off-by: Peng Tao <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.