This repository has been archived by the owner on May 6, 2020. It is now read-only.
main: Avoid duplication in makeVersionString() #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM
|
jodh-intel
force-pushed
the
simplify-makeVersionString
branch
from
a2713a1
to
f1c7897
Compare
1 similar comment
Simplified makeVersionString() to avoid duplicating string literals. Fixes clearcontainers#554. Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel
force-pushed
the
simplify-makeVersionString
branch
from
f1c7897
to
44fb418
Compare
mcastelino
pushed a commit
to mcastelino/runtime
that referenced
this pull request
Dec 6, 2018
# Kata Containers 1.2.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified makeVersionString() to avoid duplicating string literals.
Fixes #554.
Signed-off-by: James O. D. Hunt [email protected]