This repository has been archived by the owner on May 6, 2020. It is now read-only.
scripts: Add bash tab completion script #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamwhaley
approved these changes
Sep 15, 2017
| @@ -250,6 +250,7 @@ func createRuntimeApp(args []string) error { | |||
| app.Flags = runtimeFlags | |||
| app.Commands = runtimeCommands | |||
| app.Before = runtimeBeforeSubcommands | |||
| app.EnableBashCompletion = true | |||
There was a problem hiding this comment.
Had to go look that up... https://github.com/urfave/cli#bash-completion :-)
Add tab completion script for bash(1) to make working with the runtime "standalone" more comfortable and efficient. Fixes clearcontainers#562. Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel
force-pushed
the
add-bash-completion
branch
from
b3c07e0
to
10730ba
Compare
mcastelino
pushed a commit
to mcastelino/runtime
that referenced
this pull request
Dec 6, 2018
When starting a kata container, if both initrd and rootfs are provided in the configuration file then the error message presented is "cannot specify an image and an initrd in configuration file" which might be a bit confusing. This fix makes the error message more explicit. Fixes: clearcontainers#563 Signed-off-by: Nitesh Konkar [email protected]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tab completion script for bash(1) to make working with the
runtime "standalone" more comfortable and efficient.
Fixes #562.
Signed-off-by: James O. D. Hunt [email protected]