Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

checkcommits: Fix tests running in a CI environment. #64

Merged

Conversation

jodh-intel
Copy link
Contributor

TestGetCommitAndBranch() was failing in a CI environment as it was
triggering the CI-detection code. Unset all CI variables after saving
them for sane test behaviour.

Signed-off-by: James O. D. Hunt [email protected]

TestGetCommitAndBranch() was failing in a CI environment as it was
triggering the CI-detection code.  Unset all CI variables after saving
them for sane test behaviour.

Signed-off-by: James O. D. Hunt <[email protected]>
@dlespiau
Copy link
Contributor

dlespiau commented Jun 15, 2017

lgtm

Approved with PullApprove

@devimc
Copy link

devimc commented Jun 15, 2017

lgtm

Approved with PullApprove Approved with PullApprove

@devimc devimc merged commit b8beddd into clearcontainers:master Jun 15, 2017
jodh-intel added a commit to jodh-intel/cc-oci-runtime that referenced this pull request Jun 23, 2017
checkcommits has been running successfuly for a while now, so disallow
it failing in a CI environment.

Additionally, only run it in a TravisCI environment since it cannot
currently work under SemaphoreCI (due to its restrictive environment).

Fixes intel#967 (but actually fixed by clearcontainers/tests#64).

Signed-off-by: James O. D. Hunt <[email protected]>
mcastelino pushed a commit to mcastelino/tests that referenced this pull request Jan 23, 2019
…ntributing

Docs : Add minimal contribution guidelines
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants