Skip to content

Commit

Permalink
Compare certificates byte-by-byte as DER
Browse files Browse the repository at this point in the history
This is to accommodate for the concerns raised by @kse-clearhaus in
#7 (comment)

See also ruby/openssl#158
  • Loading branch information
ct-clearhaus committed May 22, 2018
1 parent 3dd3367 commit 76c7555
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/pedicel/base.rb
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ def self.extract_certificates(signature:, config: Pedicel::DEFAULT_CONFIG)
end

def self.verify_root_certificate(root:, trusted_root:)
raise SignatureError, 'root certificate is not trusted' unless root == trusted_root
raise SignatureError, 'root certificate is not trusted' unless root.to_der == trusted_root.to_der

true
end
Expand Down

0 comments on commit 76c7555

Please sign in to comment.