Pin exact dependencies #1002
Closed
Pin exact dependencies #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwilcox
approved these changes
Nov 6, 2023
JamieMagee
force-pushed
the
pin-dependencies
branch
2 times, most recently
from
1b53b88
to
78e9caa
Compare
For applications, it's considered best practices to pin exact versions of dependencies. This change removes the semantic version range specifiers, and pins each dependency to the maximum allowed by the range specifier. This makes the implicit updates explicit. For example: - `^1.0.0` will have been upgraded to the maximum minor version available. Equivalent to `1.0.0 <= x < 2.0.0` - `~1.0.0` will have been upgraded to the maximum patch version available. Equivalent to `1.0.0 <= x < 1.1.0`
JamieMagee
force-pushed
the
pin-dependencies
branch
from
78e9caa
to
897b649
Compare
|
Looks like there might be some breaking changes, despite the fact that npm packages are supposed to follow semantic versioning. I'll break this down into smaller changes and merge it piece-by-piece instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For applications it's considered a best practice to pin exact versions of dependencies.
This change removes the semantic version range specifiers and pins each dependency to the maximum allowed by the range specifier. This makes the implicit updates explicit. For example:
^1.0.0will have been upgraded to the maximum minor version available. Equivalent to1.0.0 <= x < 2.0.0~1.0.0will have been upgraded to the maximum patch version available. Equivalent to1.0.0 <= x < 1.1.0