Remove jQuery #54
Merged
Remove jQuery #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And and BTW, I've tested docdash in IE, and I guess we do not have to worry here; the whole site (CSS) is broken there anyway (note this is your unmodified example): So can we drop IE support? |
|
It only means none of the current users use IE. 😃 But since it has been discovered, I think we will need to address that for at least, as you say, IE9 |
|
Hmm, I just tried and it seems to be working without problems right now
|
|
Ah, yes, it was this compatibility view. |
|
So how about this? Save to merge? |
|
If you've tested it, I guess it was. At least theoretically... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53
I've only tested it partially in browser, but I may do a full test later.
Also, I really just transferred the jQuery logic 1:1, you can see it is often very suboptimal and could be imroved.
Expect a few pushes again.
And I do see it as a big improvment to get rid of this big, big library for just 200 LOC...