-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(clerk-js): Avoid depending on count
as it can be zero but invitations may still exist
#3092
fix(clerk-js): Avoid depending on count
as it can be zero but invitations may still exist
#3092
Conversation
🦋 Changeset detectedLatest commit: d0f8df5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
!preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ what is the actual use case where we want to have count 0
with invitations?
If there is no case (product wise) i think we need to open a bug ticket to the backend team to fix this.
Hey @octoper, your preview is available.
|
@dimkl I updated the description. Generally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
…ations may still exist
a8ac625
to
51af601
Compare
…ot-update-the-organization
@panteliselef Is the |
Description
Background: In order to provide a better UX, we are manually updating the cache where userInvitations are stored. This allows us to update the invitation in place and avoid layout shifts, if we would simply revalidate this would not be possible.
We are also manually updating
count
in the local cache in order to display the correct number of invitations available, without revalidating as this would cause a layout shift.Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change