Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clerk-js): Allow members with membership read permissions to see memberships count #3093

Conversation

octoper
Copy link
Member

@octoper octoper commented Apr 2, 2024

Description

This PR fixes an issue for the <OrganizationSwitcher/> component, where organization members with only org:sys_memberships:read could not see the counter on the Members tab.

Before

CleanShot 2024-04-02 at 16 39 16@2x

After

CleanShot 2024-04-02 at 16 38 26@2x

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Apr 2, 2024

🦋 Changeset detected

Latest commit: 85c3d21

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@octoper
Copy link
Member Author

octoper commented Apr 2, 2024

!preview

@clerk-cookie
Copy link
Collaborator

clerk-cookie commented Apr 2, 2024

Hey @octoper, your preview is available.

Status Preview Updated (UTC)
🍪 Deployed Visit preview Apr 02, 2024 01:46 PM

@octoper octoper merged commit d422dae into main Apr 2, 2024
10 checks passed
@octoper octoper deleted the vaggelis/sdk-1577-organization-members-badge-shows-0-when-members-exist branch April 2, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants