fix(clerk-js): Fix unsafe window.addEventListener() call #3097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-browser environments
🦋 Changeset detectedLatest commit: e53143b The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
!snapshot |
|
Hey @BRKalow - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i [email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact |
BRKalow
changed the title
BRKalow
commented
Apr 3, 2024
| @@ -722,16 +722,16 @@ export class Clerk implements ClerkInterface { | |||
| // undefined, then wait for beforeEmit to complete before emitting the new session. | |||
| // When undefined, neither SignedIn nor SignedOut renders, which avoids flickers or | |||
| // automatic reloading when reloading shouldn't be happening. | |||
| const beforeUnloadTracker = createBeforeUnloadTracker(); | |||
| const beforeUnloadTracker = this.#options.standardBrowser ? createBeforeUnloadTracker() : undefined; | |||
There was a problem hiding this comment.
Alternatively, have the factory function accept an argument to indicate whether or not it's a web browser environment.
panteliselef
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a customer-reported issue where we were attempting to call
window.addEventListener()via our Expo SDK.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change