Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(astro,clerk-js): Inject windowNavigate through router functions #3922

Merged

Conversation

panteliselef
Copy link
Member

Description

In some cases (like in Astro) we want to reconstruct the original windowNavigate functionality, that is because the framework might not have a router.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

In some cases (like in Astro) we want to reconstruct the original windowNavigate functionality, that is because the framework might not have a router.
@panteliselef panteliselef self-assigned this Aug 8, 2024
Copy link

changeset-bot bot commented Aug 8, 2024

🦋 Changeset detected

Latest commit: 3d9c1b3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@clerk/clerk-js Minor
@clerk/astro Minor
@clerk/types Minor
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/backend Patch
@clerk/elements Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/localizations Patch
@clerk/nextjs Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch
@clerk/shared Patch
@clerk/tanstack-start Patch
@clerk/testing Patch
@clerk/themes Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

…ndownavigate-from-astro

# Conflicts:
#	packages/astro/src/internal/create-clerk-instance.ts
@panteliselef panteliselef enabled auto-merge (squash) August 13, 2024 18:06
@panteliselef panteliselef merged commit dc0e1c3 into main Aug 13, 2024
18 checks passed
@panteliselef panteliselef deleted the elef/eco-50-refactor-duplicate-windownavigate-from-astro branch August 13, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants