-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(elements): Add support for sign in with email_link via redirect_url #3926
Conversation
🦋 Changeset detectedLatest commit: 57061c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
params: context.currentFactor as PrepareFirstFactorParams, | ||
params: { | ||
...context.currentFactor, | ||
redirectUrl: `${window.location.origin}${context.basePath}${MAGIC_LINK_VERIFY_PATH_ROUTE}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might make sense for this URL to be built somewhere else. In clerk-js we have a buildURL helper that handles appending the origin based on the routing type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the flow, and successfully signing in via email link flows
Description
This PR adds the required
redirectUrl
parameter to the prepare call for email_link first factor verification. Currently this only work if Account Portal is disabled.Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change