Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(localizations): Add Icelandic (is-IS) to localizations package #3953

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

bjaben
Copy link
Contributor

@bjaben bjaben commented Aug 14, 2024

Description

Adding support for the Icelandic (is-IS) localization to the localizations package.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Aug 14, 2024

🦋 Changeset detected

Latest commit: 7af822d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/localizations Minor
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@anagstef
Copy link
Member

Hello and thank you for contributing!

Can you please run npm run generate inside the packages/localizations directory (after running npm i and npm run build at the root dir for the project)? 🙏

@bjaben
Copy link
Contributor Author

bjaben commented Aug 16, 2024

Hello and thank you for contributing!

Can you please run npm run generate inside the packages/localizations directory (after running npm i and npm run build at the root dir for the project)? 🙏

Done 😃

Copy link
Member

@anagstef anagstef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You! 🙏

@tmilewski tmilewski merged commit e5491fa into clerk:main Aug 16, 2024
5 of 15 checks passed
BRKalow pushed a commit that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants