-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(astro): Add support for custom menu items #3969
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7542e82 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wobsoriano
changed the title
feat(astro): Add custom menu items
feat(astro): Add support for custom menu items
Aug 16, 2024
LekoArts
requested changes
Aug 16, 2024
packages/astro/src/astro-components/interactive/UserButton/MenuItemRenderer.astro
Outdated
Show resolved
Hide resolved
packages/astro/src/astro-components/interactive/UserButton/UserButtonAction.astro
Outdated
Show resolved
Hide resolved
Co-authored-by: Lennart <[email protected]>
wobsoriano
commented
Aug 18, 2024
packages/astro/src/astro-components/interactive/UserButton/MenuItemRenderer.astro
Show resolved
Hide resolved
LekoArts
approved these changes
Aug 19, 2024
BRKalow
pushed a commit
that referenced
this pull request
Aug 22, 2024
Co-authored-by: Lennart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for custom menu items in the
<UserButton />
Astro component. It implements the same behavior with the React counterpart, with two exceptions:onClick
prop for custom actions is not implemented, since Astro components are executed on the server and is serialized. Instead, we're using aCustomEvent
with aclickIdentifier
prop to identify which menu item has been clicked. Maybe we can removeclickIdentifier
and just use thelabel
as identifier?labelIcon
prop is now a slot.React components to follow.
Closes ECO-130
Usage:
Closes ECO-130
Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change