Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clerk-js): Better CAPTCHA widget console error #3989

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Conversation

agis
Copy link
Member

@agis agis commented Aug 20, 2024

This PR improves the error message thrown when falling back to invisible CAPTCHA, if the captcha DOM element is not found.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@agis agis requested a review from anagstef August 20, 2024 10:39
Copy link

changeset-bot bot commented Aug 20, 2024

🦋 Changeset detected

Latest commit: 5c5e574

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@anagstef anagstef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@agis agis requested a review from nikosdouvlis August 20, 2024 10:53
@agis agis merged commit e81d9a5 into main Aug 20, 2024
21 checks passed
@agis agis deleted the captcha-dom-error branch August 20, 2024 11:25
BRKalow pushed a commit that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants