Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Add logoVisibility prop functionality #4202

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

alexcarpenter
Copy link
Member

@alexcarpenter alexcarpenter commented Sep 20, 2024

Description

Removes logoPlacement option in favor of logoVisibility and implements visibility logic to conditionally show/hide the logos in sign-in/up components.

VISIBLE HIDDEN
Screenshot 2024-09-20 at 1 02 10 PM Screenshot 2024-09-20 at 12 58 54 PM

Fixes SDKI-558

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Sep 20, 2024

🦋 Changeset detected

Latest commit: efc2fcb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alexcarpenter alexcarpenter self-assigned this Sep 20, 2024
@alexcarpenter alexcarpenter merged commit 11ebd02 into main Sep 23, 2024
20 checks passed
@alexcarpenter alexcarpenter deleted the alexcarpenter/sdki-558-logoplacement branch September 23, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants