Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clerk-js): Initialize default role with form controls #4281

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

LauraBeatris
Copy link
Member

@LauraBeatris LauraBeatris commented Oct 3, 2024

Description

Fixes issue where "Send invitation" button is getting disabled even tho there's a default role loaded:

CleanShot.2024-10-03.at.17.33.17.mp4

The issue relies on the fact that we're overriding the field.value property when rendering it, instead of passing it to the form controls state:

CleanShot.2024-10-03.at.17.31.11.mp4

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@LauraBeatris LauraBeatris self-assigned this Oct 3, 2024
Copy link

changeset-bot bot commented Oct 3, 2024

🦋 Changeset detected

Latest commit: 6a0e07a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LauraBeatris LauraBeatris changed the title fix(clerk-js): Initialize default role as part of form schema fix(clerk-js): Initialize default role as part of form schema Oct 3, 2024
@LauraBeatris LauraBeatris changed the title fix(clerk-js): Initialize default role as part of form schema fix(clerk-js): Initialize default role as part of form controls Oct 3, 2024
@LauraBeatris LauraBeatris changed the title fix(clerk-js): Initialize default role as part of form controls fix(clerk-js): Initialize default role as part of form controls Oct 3, 2024
@LauraBeatris LauraBeatris force-pushed the laura/fix-default-role-form-state branch from 7119b0f to 6e9c3bf Compare October 3, 2024 20:22
@LauraBeatris LauraBeatris changed the title fix(clerk-js): Initialize default role as part of form controls fix(clerk-js): Initialize default role with form controls Oct 3, 2024
@LauraBeatris LauraBeatris marked this pull request as ready for review October 3, 2024 20:36
@LauraBeatris LauraBeatris force-pushed the laura/fix-default-role-form-state branch from b5a0fd1 to 6a0e07a Compare October 3, 2024 21:09
@LauraBeatris LauraBeatris merged commit d2ec88e into main Oct 4, 2024
21 checks passed
@LauraBeatris LauraBeatris deleted the laura/fix-default-role-form-state branch October 4, 2024 09:08
@FranciscoMoretti
Copy link

Hi, thanks for fixing this! I see that @clerk/[email protected] was released with this update.

How does this reach @clerk/clerk-react?

@LauraBeatris
Copy link
Member Author

Hi, thanks for fixing this! I see that @clerk/[email protected] was released with this update.

How does this reach @clerk/clerk-react?

Hi @FranciscoMoretti! We haven't deployed this change to our CDN workers yet, so this is not fully released. For further context, clerk-js is hot-loaded from a CDN in the browser, so it doesn't require a library update on your end.

@LauraBeatris
Copy link
Member Author

@FranciscoMoretti It's deployed now, you will see the latest fix on your app!

@FranciscoMoretti
Copy link

@LauraBeatris thank you so much for the detailed explanation and update! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants