chore(clerk-js): Update OrganizationSwitcher popover action to include label
#4304
Conversation
🦋 Changeset detectedLatest commit: 6835e97 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LauraBeatris
changed the title
OrganizationSwitcher popover small gear icon with a Manage labelOrganizationSwitcher popover small gear icon with labelled action
LauraBeatris
force-pushed
the
laura/orgs-246-replace-organizationswitcher-gear-icon-with-a-manage-button
branch
from
994a014
to
0a32365
Compare
|
Q to consider: should we offer an option to reverse this and just go to the gear icon? (aka does this break a contract we have with our users?) |
@kylemac I think this won't be needed, cause we're still keeping the same UI hierarchy here with a
Depending on how folks are relying on this for things such as UI tests, then it could break when bumping the version, but still, I wouldn't consider that valuable in order to introduce a property for this behavior 🤔 |
LauraBeatris
changed the title
OrganizationSwitcher popover small gear icon with labelled actionOrganizationSwitcher popover action to include label
| @@ -105,20 +104,6 @@ export const OrganizationSwitcherPopover = React.forwardRef<HTMLDivElement, Orga | |||
| }); | |||
| }; | |||
|
|
|||
| const manageOrganizationSmallIconButton = ( | |||
There was a problem hiding this comment.
Now we're reusing the action that used to be displayed only when there was a __unstable_manageBillingUrl.
LauraBeatris
deleted the
laura/orgs-246-replace-organizationswitcher-gear-icon-with-a-manage-button
branch
Description
Resolves ORGS-246
Replaces
OrganizationSwitchersmall gear icon action with a labeled button to make it less confusing to end-users.Now:
Previously:
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change