fix/add-error-message-for-other-module-not-found

[JohnDaly]

If there is a require statement in the 'eslint-local-rules' file, which results in a MODULE_NOT_FOUND error, its not immediately obvious with the current error messaging.

// eslint-local-rules.js

// Will cause a 'MODULE_NOT_FOUND' error
require('bad-import-which-will-not-resolve');

module.exports = {
  'disallow-identifiers': {
    meta: {
      docs: {
        description: 'disallow identifiers',
        category: 'Possible Errors',
        recommended: false,
      },
      schema: [],
    },
    create: function(context) {
      return {
        Identifier: function(node) {
          context.report({
            node: node,
            message: 'Identifiers not allowed for Super Important reasons.',
          });
        },
      };
    },
  },
};

Will result in the following error:

 Error: eslint-plugin-local-rules: Cannot find "eslint-local-rules{.js,.cjs} or eslint-local-rules/index.js (checked all
    ancestors of "path/to/eslint-plugin-local-rules").

This PR will make it so that the Cannot find module 'bad-import-which-will-not-resolve' error will be thrown

[cletusw]

Great find & fix! I simplified the code a little -- let me know if it's still good and I'll get it merged, thanks!

[JohnDaly]

Great find & fix! I simplified the code a little -- let me know if it's still good and I'll get it merged, thanks!

Looks great!

[cletusw]

Merged and released v1.1.1, thanks for the fix!

[diegocr]

Guys, I think this PR is causing the issue pointed in #7 since i never encountered it before with 1.1.0

Error: Failed to load plugin 'local-rules' declared in '.eslintrc.json': eslint-plugin-local-rules: Cannot find "eslint-local-rules{.js,.cjs} or eslint-local-rules/index.js (...).

Noteworthy, i don't have any require() call into my eslint-local-rules.js

Can you please look at fixing this at your earliest convenience? Thanks in advance!

[cletusw]

@diegocr Sorry about that!! I was literally just thinking how bad it is this thing doesn't have a single test. Reverted this changed and published as v1.1.2. I'll try again more carefully -- if you have a simplified version of your setup that errors in v1.1.1 that I can test against that would be great, thanks.

[JohnDaly]

@cletusw I missed this earlier, but filepath needs to be defined within the scope of the for loop so that it can access i

[JohnDaly]

In v1.1.1, the filepath variable evaluates to /path/to/eslint-local-rulesundefined.

This will cause MODULE_NOT_FOUND errors, an example might look like:

Error: Cannot find module '/path/to/eslint-local-rulesundefined'

Since this error message matches the pattern Cannot find module '${filepath}' that we check for, an error is not thrown, and this results in the standard 'Failed to load plugin' error being logged