Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with project names with dashes #7

Closed
gimenete opened this issue Feb 2, 2018 · 4 comments
Closed

Problem with project names with dashes #7

gimenete opened this issue Feb 2, 2018 · 4 comments
Labels
bug Something isn't working

Comments

@gimenete
Copy link
Contributor

gimenete commented Feb 2, 2018

docker-compose has problems with project names with dashes.
docker/compose#869

One way to fix this is to just remove the dashes when the project name is replaced here: https://github.com/clevertech/boilerplate/blob/master/docker/run#L5

There's a script that clones the project and replaces the name of the project in multiple files: https://github.com/clevertech/boilerplate/tree/create-boilerplate-app

for docker/run it should remove the dashes

@nstraub
Copy link

nstraub commented Feb 2, 2018

Could we change dashes to snake_case? (to keep the names clear)

@gimenete
Copy link
Contributor Author

gimenete commented Feb 2, 2018

Sure 👍 if that works

@nstraub
Copy link

nstraub commented Feb 3, 2018

I ended up fixing it without having to sacrifice dashes... so it's still consistent. I'll push as soon as I have write permissions.
I did change some dashes with underscores though... the ones pertaining to db users and names. Since databases don't like hyphens in their names I figured it'd be best to use undersores

@nstraub nstraub added the bug Something isn't working label Feb 10, 2018
gimenete added a commit that referenced this issue Feb 16, 2018
Fixes create boilerplate app - issue #7: Problem with project names w…
@chadfurman
Copy link

we should close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants