-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tab-completion for Path and BOOL type arguments #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorted tests: tests/test_command_collection.py Moved tests to other files: tests/test_complete.py Sorted tests: tests/test_completion/test_click_version_ge_8/test_arg_completion_v8.py Sorted tests: tests/test_completion/test_click_version_ge_8/test_option_completion_v8.py Sorted tests: tests/test_completion/test_click_version_le_7/test_arg_completion_v7.py Sorted tests: tests/test_completion/test_click_version_le_7/test_option_completion_v7.py Sorted tests: tests/test_completion/test_common_tests/test_arg_completion.py Sorted tests: tests/test_completion/test_common_tests/test_hidden_cmd_and_args.py Sorted tests: tests/test_completion/test_common_tests/test_option_completion.py Sorted tests: tests/test_completion/test_path_type/test_path_type.py Sorted tests: tests/test_dev/test_internal_cmds.py Sorted tests: tests/test_dev/test_sys_cmds.py Sorted tests: tests/test_repl.py test file for path testing: tests/testdir/test file.txt
Added Path completion code: click_repl/_completer.py Moved repl code to here: click_repl/_repl.py modified: click_repl/exceptions.py Sorted code into separate files: click_repl/utils.py
GhostOps77
changed the title
Added tab-completion for Path type arguments
Added tab-completion for Path and BOOL type arguments
Mar 23, 2023
Lost the `u` prefix while formatting the code
auvipy
requested changes
Mar 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am curious why python 2 compatibility should still be kept?
@auvipy there's no python 2 support in this PR, you can merge this PR without any issues After merging this PR, you can close this issue |
Added py3.11 and py3.12 test tox env's
auvipy
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the tab-completion feature for Path type and as well as for
BOOL
type, with some test cases for them