Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tab-completion for Path and BOOL type arguments #95

Merged
merged 10 commits into from
Mar 24, 2023

Conversation

GhostOps77
Copy link
Contributor

@GhostOps77 GhostOps77 commented Mar 23, 2023

Added the tab-completion feature for Path type and as well as for BOOL type, with some test cases for them

	Sorted tests:   tests/test_command_collection.py
	Moved tests to other files:    tests/test_complete.py
	Sorted tests:   tests/test_completion/test_click_version_ge_8/test_arg_completion_v8.py
	Sorted tests:   tests/test_completion/test_click_version_ge_8/test_option_completion_v8.py
	Sorted tests:   tests/test_completion/test_click_version_le_7/test_arg_completion_v7.py
	Sorted tests:   tests/test_completion/test_click_version_le_7/test_option_completion_v7.py
	Sorted tests:   tests/test_completion/test_common_tests/test_arg_completion.py
	Sorted tests:   tests/test_completion/test_common_tests/test_hidden_cmd_and_args.py
	Sorted tests:   tests/test_completion/test_common_tests/test_option_completion.py
	Sorted tests:   tests/test_completion/test_path_type/test_path_type.py
	Sorted tests:   tests/test_dev/test_internal_cmds.py
	Sorted tests:   tests/test_dev/test_sys_cmds.py
	Sorted tests:   tests/test_repl.py
	test file for path testing:   tests/testdir/test file.txt
	Added Path completion code:   click_repl/_completer.py
	Moved repl code to here:   click_repl/_repl.py
	modified:   click_repl/exceptions.py
	Sorted code into separate files:   click_repl/utils.py
@GhostOps77 GhostOps77 changed the title Added tab-completion for Path type arguments Added tab-completion for Path and BOOL type arguments Mar 23, 2023
Copy link
Collaborator

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious why python 2 compatibility should still be kept?

@GhostOps77
Copy link
Contributor Author

GhostOps77 commented Mar 24, 2023

@auvipy there's no python 2 support in this PR, you can merge this PR without any issues

After merging this PR, you can close this issue

@GhostOps77 GhostOps77 requested a review from auvipy March 24, 2023 07:58
Added py3.11 and py3.12 test tox env's
@auvipy auvipy merged commit a068e82 into click-contrib:master Mar 24, 2023
@GhostOps77 GhostOps77 deleted the path-tab-completion branch March 24, 2023 12:54
@GhostOps77 GhostOps77 restored the path-tab-completion branch May 4, 2024 10:04
@GhostOps77 GhostOps77 deleted the path-tab-completion branch May 4, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants