Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #92 #97

Merged
merged 2 commits into from
May 21, 2023
Merged

Fix for issue #92 #97

merged 2 commits into from
May 21, 2023

Conversation

flacoste
Copy link
Contributor

I've added three tests:

Not sure yet on how to make them pass, welcoming any ideas.

@auvipy auvipy self-requested a review March 29, 2023 08:28
@flacoste
Copy link
Contributor Author

After investigation, I realized that calling the group() command on every subcommand is part of click's expected behavior so it should be preserved. Once it's known, it's still possible to take advantage of the group context caching. The fix for the arguments is to use group.invoke() to make the dispatch by passing the new args in the context.

@flacoste flacoste changed the title Add tests for issue #92 Fix for issue #92 Mar 29, 2023
@GhostOps77
Copy link
Contributor

Hi @flacoste , any updates on making these test cases?

Copy link
Collaborator

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking forward to the remaining stuff in this PR

Copy link
Collaborator

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging as part of fix

@auvipy auvipy merged commit f3694c7 into click-contrib:master May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants