Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binning #27

Merged
merged 50 commits into from
May 3, 2024
Merged

Binning #27

merged 50 commits into from
May 3, 2024

Conversation

znichollscr
Copy link
Contributor

@znichollscr znichollscr commented Apr 16, 2024

Will contribute to:

Checklist:

  • add the CH4 creation notebooks into our pydoit setup
  • add CI that goes end to end for CH4 files
  • delete now unused, temporary/example gridding stuff

@znichollscr znichollscr marked this pull request as ready for review May 3, 2024 03:39
Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 79.18871% with 118 lines in your changes are missing coverage. Please review.

Project coverage is 88.62%. Comparing base (37648ef) to head (7900a33).

Files Patch % Lines
src/local/mean_preserving_interpolation.py 66.31% 32 Missing ⚠️
src/local/config_creation/noaa_handling.py 50.00% 20 Missing ⚠️
src/local/config_creation/law_dome_handling.py 44.44% 10 Missing ⚠️
src/local/xarray_time.py 73.68% 10 Missing ⚠️
src/local/binned_data_interpolation.py 84.90% 8 Missing ⚠️
...l/config_creation/monthly_fifteen_degree_pieces.py 38.46% 8 Missing ⚠️
src/local/config_creation/agage_handling.py 46.15% 7 Missing ⚠️
src/local/binning.py 91.30% 6 Missing ⚠️
src/local/latitudinal_gradient.py 75.00% 6 Missing ⚠️
src/local/config_creation/crunch_grids.py 44.44% 5 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   97.34%   88.62%   -8.73%     
==========================================
  Files          44       65      +21     
  Lines         867     1389     +522     
==========================================
+ Hits          844     1231     +387     
- Misses         23      158     +135     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@znichollscr
Copy link
Contributor Author

Good enough to merge, can figure out the rest from here

@znichollscr znichollscr merged commit e0f72db into main May 3, 2024
4 of 5 checks passed
@znichollscr znichollscr deleted the binning branch May 3, 2024 04:10
@znichollscr znichollscr mentioned this pull request May 12, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant