cider-eval: support re-rendering the Inspector buffer when cider-inspector-auto-select-buffer is set to nil and there's a *cider-inspect* buffer shown in a non-visible frame
#3634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sible in another frame and `select` is nil This seems the right thing to do.
…nspector-auto-select-buffer` is set to nil and there's a `*cider-inspect*` buffer shown in a non-visible frame This supports the workflow of using the inspector occasionally (less intrusively), but ready to be shown anytime.
If there's already a `*cider-inspect*` buffer visible, we shouldn't suggest the user to inspect the value again.
vemv
force-pushed
the
cider-inspect-defcustoms
branch
from
66b577d
to
657b2d3
Compare
vemv
changed the title
cider-eval: Introduce new cider-auto-inspect-after-eval-select-window defcustomcider-eval: support re-rendering the Inspector buffer when cider-inspector-auto-select-buffer is set to nil and there's a *cider-inspect* buffer shown in a non-visible frame
|
I reworked this PR to not introduce any defcustoms - ready now! |
|
Thanks for the update, I'll review it tomorrow. |
bbatsov
reviewed
Mar 15, 2024
| @@ -826,6 +826,24 @@ KIND can be the symbols `ns', `var', `emph', `fn', or a face name." | |||
| (t x))) | |||
| menu-list)) | |||
|
|
|||
| ;; Defined here to avoid circular dependencies | |||
| (defconst cider-inspector-buffer "*cider-inspect*") | |||
There was a problem hiding this comment.
Hmm, I'm not sure I like this, because the way I see it the inspector shouldn't be depending on cider-eval and now we're kind of sweeping this odd dependency under the rug.
|
I checked the |
|
@alexander-yakushev Any thoughts on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My overall intent is the possibility to have the
*cider-inspect*buffer permanently on a background frame. cider-eval would have that frame's cider-inspect buffer re-rendered, without switching to it, given that I personally find that only a fraction of evals deserve inspection.This wasn't possible before, as CIDER would detect that my frame wasn't visible, so it would render the buffer in a random window of the visible frame.
Commits:
cider-popup-buffer-display: Do nothing if the intended buffer is visible in another frame andselectis nilcider-eval: support re-rendering the Inspector buffer whencider-inspector-auto-select-bufferis set to nil and there's a*cider-inspect*buffer shown in a non-visible frameResult truncatedmessage more accurate*cider-inspect*buffer visible, we shouldn't suggest the user to inspect the value again.Cheers - V