Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PyPy 2 build #116

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Fix PyPy 2 build #116

merged 1 commit into from
Oct 26, 2021

Conversation

movermeyer
Copy link
Collaborator

What are you trying to accomplish?

Fix the build failure for PyPy 2

This wasn't noticed as part of v2.2.0, since that version of PyPy hadn't yet been released (it had been merged, but not released).

What approach did you choose and why?

The check for whether PyPy supported the cPython 3.7's Timezone API was insufficient. It was just checking the PyPy version number, which is something that both PyPy 2 and PyPy 3 share.

We also still need to check the Python version.

What should reviewers focus on?

🤷

The impact of these changes

Builds will once again work for PyPy 2.

Testing

...

@movermeyer movermeyer merged commit 3d91914 into master Oct 26, 2021
@movermeyer movermeyer mentioned this pull request Oct 26, 2021
@movermeyer movermeyer mentioned this pull request Nov 22, 2022
@movermeyer movermeyer deleted the mo.fix_pypy2_build branch December 21, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant