Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tencent] Change All Error Messages to English #1053 #1054

Merged
merged 3 commits into from
Feb 7, 2024
Merged

[Tencent] Change All Error Messages to English #1053 #1054

merged 3 commits into from
Feb 7, 2024

Conversation

raccoon-mh
Copy link
Member

  • 출력 되는 로그 메시지 영어로 변경하였습니다.
  • The output log message has been changed to English.
##AS-IS
     cblogger.Error("Connection 정보에 Zone 정보가 없습니다.") 

##TO-BE
     cblogger.Error("Connection information does not contain Zone information.")

@powerkimhub powerkimhub self-requested a review February 7, 2024 06:14
@raccoon-mh raccoon-mh mentioned this pull request Feb 7, 2024
Closed
powerkimhub
powerkimhub reviewed Feb 7, 2024
View reviewed changes
cloud-control-manager/cloud-driver/drivers/tencent/TencentDriver.go Outdated
@@ -68,7 +68,7 @@ func getVmClient(connectionInfo idrv.ConnectionInfo) (*cvm.Client, error) {

zoneId := connectionInfo.RegionInfo.Zone
if len(zoneId) < 1 {
cblogger.Error("Connection 정보에 Zone 정보가 없습니다.")
cblogger.Error("Connection information does not contain Zone information.")
return nil, errors.New("Connection 정보에 Zone 정보가 없습니다")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 반환 되는 에러도 영어 메시지로 부탁 드립니다.
  • 결국, 상위 계층에서 로그로 출력 가능성이 있습니다.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

더 찾아보니 21년 작업했던 드라이버에 한글 리턴이나 info, err 가 있네요..

https://github.com/cloud-barista/cb-spider/blob/master/cloud-control-manager/cloud-driver/drivers/alibaba/resources/VMSpecHandler.go

우선 위에 말씀해주셨던 부분만 수정하고, 나머지는 별도 이슈로 처리하겠습니다.

powerkimhub
powerkimhub requested changes Feb 7, 2024
View reviewed changes
Copy link
Member

@powerkimhub powerkimhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 함수에서 반환 되는 에러 메시지도 점검 부탁드립니다.

@powerkimhub powerkimhub merged commit cc4f629 into cloud-barista:master Feb 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powerkimhub powerkimhub powerkimhub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raccoon-mh @powerkimhub