Modify workflow to make comments only when Korean texts are included #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will modify the workflow to make comments only when Korean texts are included in later PRs.
I'd like to open this PR in advance. (I think it's okay if it will be decided later.)
Why it is needed
: In the current workflow, comments are left both when the PR contains Korean text and when it does not.
: There are definitely pros and cons to leaving a comment, even when it doesn't include Korean text.
Proposal
: I think it would be good to merge or close this PR at an appropriate time later.
Note - no conflict with other PR is expected.