Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated command with environment file #1318

Merged
merged 1 commit into from
Sep 3, 2023
Merged

Replace deprecated command with environment file #1318

merged 1 commit into from
Sep 3, 2023

Conversation

jongwooo
Copy link
Contributor

@jongwooo jongwooo commented Sep 3, 2023

Description

Closes #1317

Update .github/workflows/publish-multi-arch-container-images.yaml to use environment file instead of deprecated set-output command.
For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the workflow file that use set-output command through the following command:

$ find . -name '*.yml' -o -name '*.yaml' | xargs egrep '\bset-output\b'

AS-IS

echo ::set-output name=docker-tags::${DOCKER_TAGS}

TO-BE

echo "docker-tags=${DOCKER_TAGS}" >> $GITHUB_OUTPUT

@seokho-son
Copy link
Member

Hi @jongwooo
Thanks for the report and replacement!
LGTM.

@seokho-son
Copy link
Member

/approve

@seokho-son seokho-son merged commit e99545b into cloud-barista:main Sep 3, 2023
1 check passed
@jongwooo jongwooo deleted the chore/replace-deprecated-command-with-environment-file branch September 3, 2023 16:46
@seokho-son
Copy link
Member

@all-contributors please add @jongwooo for Code

@allcontributors
Copy link
Contributor

@seokho-son

I've put up a pull request to add @jongwooo! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated set-output command with environment file
2 participants