Apply zerolog to some parts of mcis dynamic provision

[seokho-son]

Found

• Add Zerolog-based logger and update dependencies #1477 is very useful !

Trying to apply it to some parts of mcis dynamic provision.

[seokho-son]

PTAL: @yunkon-kim :)

[yunkon-kim]

@seokho-son LGTM!

I'd like to share two useful usages.

• log.Error().Err(err).Msg("") is possible if the err object has a clear error message:
  • https://github.com/rs/zerolog?tab=readme-ov-file#error-logging
• Contextual logging (i.e., key-value type)
  • https://github.com/rs/zerolog?tab=readme-ov-file#contextual-logging

[seokho-son]

@yunkon-kim
So..

err := fmt.Errorf("Failed to get the vNet " + vmReq.VNetId + " from " + vmReq.ConnectionName)
log.Error().Err(err).Msg("Failed to get the vNet")

--> log.Error().Err(err).Msg("") is a better usage?

[yunkon-kim]

@seokho-son It depends on errors. The current code looks fine to me.

Here's an example code and result:

err := fmt.Errorf("error message from err objects")
	log.Error().Err(err).Msg("my error message")

Console

Log file

{"level":"error","error":"error message from err objects","time":"2024-04-01T17:15:54+09:00","caller":"/home/ubuntu/dev/cloud-barista/cb-tumblebug/src/api/rest/server/server.go:88","message":"my error message"}

As you can see the example,

• .Err(err) makes error field for logging (see Advanced Fields), and
• .Msg() is a general message field for all log levels.

[seokho-son]

@yunkon-kim Thanks! then, let's keep the current. Please approve (merge) if it is ok. :)