Add skip logging middleware by uri rule #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunkon-kim
reviewed
Apr 2, 2024
There was a problem hiding this comment.
Skipping some patterns is very useful! For this purpose, it would be good to use Skipper as suggested.
Additionally, we should modify some code in server.go.
- e.Use(middlewares.Zerologger())
+ skipPatterns := []string{
+ "/tumblebug/api",
+ "/mcis?option=status",
+ }
+ e.Use(middlewares.Zerologger(skipPatterns))
Comment on lines
29
to
30
| func Zerologger() echo.MiddlewareFunc { | ||
| return middleware.RequestLoggerWithConfig(middleware.RequestLoggerConfig{ |
There was a problem hiding this comment.
Suggested change
| func Zerologger() echo.MiddlewareFunc { | |
| return middleware.RequestLoggerWithConfig(middleware.RequestLoggerConfig{ | |
| func Zerologger(skipPatterns []string) echo.MiddlewareFunc { | |
| return middleware.RequestLoggerWithConfig(middleware.RequestLoggerConfig{ | |
| Skipper: func(c echo.Context) bool { | |
| for _, pattern := range skipPatterns { | |
| if strings.Contains(c.Request().URL.Path, pattern) { | |
| return true | |
| } | |
| } | |
| return false | |
| }, |
Comment on lines
44
to
46
| if skipLogging(v.URI) { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
Suggested change
| if skipLogging(v.URI) { | |
| return nil | |
| } |
Comment on lines
15
to
28
| func skipLogging(uri string) bool { | ||
| skipPatterns := []string{ | ||
| "/tumblebug/api", | ||
| "/mcis?option=status", | ||
| } | ||
|
|
||
| for _, pattern := range skipPatterns { | ||
| if strings.Contains(uri, pattern) { | ||
| return true | ||
| } | ||
| } | ||
| return false | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| func skipLogging(uri string) bool { | |
| skipPatterns := []string{ | |
| "/tumblebug/api", | |
| "/mcis?option=status", | |
| } | |
| for _, pattern := range skipPatterns { | |
| if strings.Contains(uri, pattern) { | |
| return true | |
| } | |
| } | |
| return false | |
| } |
|
Thanks @yunkon-kim |
|
/approve |
github-actions
bot
added
the
approved
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very first code ;)
skipPatterns should be injected from a higher level function.