Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to runTumblebug.sh and check readiness without auth #1559

Merged
merged 2 commits into from
May 8, 2024

Conversation

yunkon-kim
Copy link
Member

This PR includes two things:

  1. Adding endpoint selection logic to runTumblebug.sh
  2. Checking readiness without auth

Tumblebug users/developers can select the endpoints when running the Tumblebug container.

Option 1) Use the retrieved external IP and set the endpoints of SP, DF, TB as the previous
Option 2) Use host.docker.internal and localhost

  • Note: host.docker.internal is used for TB container to communicate with SP/DF containers
  • Note: localhost is used for Tumblebug SELF_ENDPOINT for serving APIs externally

Also, we can check TB readiness without auth.

* Retrieve the external IP address
* Prompt the user to select endpoints
* Options:
  1) Use External IP for all components
  2) Use 'host.docker.internal' and 'localhost
      - Note - 'host.docker.internal' to communicate with Spider and Dragonfly containers
      - Note - 'localhost' for Tumblebug itself
@yunkon-kim
Copy link
Member Author

Prompt

[Retrieve IP address accessible from outside]
Please select endpoints to be used:
1) Use External IP for all components: 129.254.75.33
2) Use 'host.docker.internal' to communicate with Spider and Dragonfly containers, 'localhost' for Tumblebug
Enter your choice (1 or 2):

The command when selecting option 1

sudo docker run --rm -p 1323:1323 \
                -v /home/ubuntu/dev/cloud-barista/cb-tumblebug/container-volume/cb-tumblebug-container:/app/meta_db \
                -e SPIDER_REST_URL=http://129.254.75.33:1024/spider -e DRAGONFLY_REST_URL=http://129.254.75.33:9090/dragonfly -e SELF_ENDPOINT=129.254.75.33:1323 \
                --name cb-tumblebug \
                cloudbaristaorg/cb-tumblebug:latest

Command when selecting option 2

sudo docker run --rm -p 1323:1323 \
                -v /home/ubuntu/dev/cloud-barista/cb-tumblebug/container-volume/cb-tumblebug-container:/app/meta_db \
                --add-host host.docker.internal:host-gateway -e SPIDER_REST_URL=http://host.docker.internal:1024/spider -e DRAGONFLY_REST_URL=http://host.docker.internal:9090/dragonfly -e SELF_ENDPOINT=localhost:1323 \
                --name cb-tumblebug \
                cloudbaristaorg/cb-tumblebug:latest

@seokho-son
Copy link
Member

Thanks! LGTM

@seokho-son
Copy link
Member

/approve

@github-actions github-actions bot added the approved This PR is approved and will be merged soon. label May 8, 2024
@cb-github-robot cb-github-robot merged commit 6d89efd into cloud-barista:main May 8, 2024
4 checks passed
@yunkon-kim
Copy link
Member Author

In the next release, checking readiness without auth will be applied to the container.

@yunkon-kim yunkon-kim deleted the 240508-10 branch June 10, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This PR is approved and will be merged soon.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants