Add APIs for VPN tunnel between GCP and AWS #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yunkon-kim
commented
May 16, 2024
yunkon-kim
commented
- Add TERRARIUM_REST_URL to setup.env
- Add APIs for VPN tunnel between GCP and AWS
- Update ResponseBodyDump() middleware to support streaming JSON response
- Update runTumblebug.sh and runTerrarium.sh
- Update test-cli for gcp-aws vpn tunnel
- Update API docs
* Add TERRARIUM_REST_URL to setup.env * Add APIs for VPN tunnel between GCP and AWS * Update ResponseBodyDump() middleware to support streaming JSON response * Update runTumblebug.sh and runTerrarium.sh * Update test-cli for gcp-aws vpn tunnel * Update API docs
seokho-son
reviewed
May 16, 2024
src/api/rest/server/mcis/network.go
Outdated
| var epTerrarium string | ||
|
|
||
| func init() { | ||
| epTerrarium = os.Getenv("TERRARIUM_REST_URL") |
There was a problem hiding this comment.
config API 로 동적으로 config (env vars)를 조정할 수 있도록 처리하려고
https://github.com/cloud-barista/cb-tumblebug/blob/main/src/main.go#L59 여기에 init 관련 내용을 모아두긴 했는데, TERRARIUM_REST_URL 에는 적용할 필요가 없으려나요?
|
Related to #1439 |
|
/approve |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.