Deduplicate code for checking k8scluster enablement #1689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seokho-son
reviewed
Jul 26, 2024
src/core/mcis/k8scluster.go
Outdated
| @@ -1932,6 +1844,69 @@ func convertSpiderNodeGroupStatusToTbK8sNodeGroupStatus(spNodeGroupStatus Spider | |||
| return TbK8sNodeGroupInactive | |||
| } | |||
|
|
|||
| func CheckK8sClusterEnablement(connectionName string) error { | |||
There was a problem hiding this comment.
대문자로 시작하는 함수이므로, 린트를 위해서 주석 추가 부탁드립니다.
(이왕이면, 나머지 소문자로 시작하는 내부 함수도 가급적 주석을 추가해주시면 좋을 것 같습니다. 현 PR에서 수정할 필요까지는 없을 것 같습니다.)
There was a problem hiding this comment.
대문자로 시작할 필요가 없는 함수였습니다.
타 내부 함수에 대한 주석을 추가한 PR은 추후 별도로 진행하겠습니다.
sykim-etri
force-pushed
the
deduplicate-check-k8scluster-enablement
branch
from
91c3bdc
to
cc5b095
Compare
sykim-etri
force-pushed
the
deduplicate-check-k8scluster-enablement
branch
from
cc5b095
to
1081fee
Compare
|
감사합니다! LGTM. |
seokho-son
approved these changes
Jul 26, 2024
|
/approve |
github-actions
bot
added
the
approved
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assets/cloud.conf에 기재된 k8scluster enablement를 확인하는 코드들의 중복을 제거하고, 클러스터 버전 확인 부분을 업데이트하였습니다.