-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add etcd-centric kvstore and replace cb-store #1690
Merged
cb-github-robot
merged 6 commits into
cloud-barista:replace-with-etcd
from
yunkon-kim:240725-09
Jul 26, 2024
Merged
Add etcd-centric kvstore and replace cb-store #1690
cb-github-robot
merged 6 commits into
cloud-barista:replace-with-etcd
from
yunkon-kim:240725-09
Jul 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `setup-auth.sh` and `.env`, which is used by Docker Compose * Set up or apply auth on etcd server through `etcd-setup-auth` (an ephemeral container) * Improve configuration for connecting to `etcd` and `kvstore` - Add environment variables of `etcd` - Read envs and set to the configs (including auth info) - Retry several times until you connect to the `etcd` server * Update examples for `etcd` test
@yunkon-kim |
@seokho-son (cc. @sykim-etri) 걱정해주셔서 감사합니다 ^^ 광범위한 변경이라서 가능한 이슈 없이 Merge 하고자 (잠시 동안) 별도의 브랜치에서 의견 수렴 및 개선을 진행하고자 했습니다. 현 개발 내용을 활용 또는 테스트 해보실 수 있도록, 일부러 upstream에 branch를 생성한 측면도 있습니다. K8s 부분은 대부분 Tumblebug에 반영해 주셨다고 합니다 ^^ 다음주 월요일까지 의견/걱정/개선 사항을 기다려보고요. 이후에 개선 또는 main에 머지하도록 하겠습니다. (참고)
|
/approve |
github-actions
bot
added
the
approved
This PR is approved and will be merged soon.
label
Jul 26, 2024
cb-github-robot
merged commit Jul 26, 2024
74ac071
into
cloud-barista:replace-with-etcd
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will replace the existing
cb-store
withkvstore
based onetcd
.Due to this,
etcd
must be running to run CB-Tumblebug. To reduce inconvenience, docker-compose can help you to deploy etcd. Byetcd-setup-auth
, simple authentication will be supported.To minimize the impact on
upstream
, I would like to open this PR targeted to a separate branch and keep testing and gathering feedback for a while.This PR includes:
kvstore
pkg:kvstore
pkg based on etcd.cb-store
with thekvstore
.kvstore
Authentication setup:
setup-auth.sh
and.env
for Docker Composeetcd-setup-auth
(ephemeral container)Configuration enhancements:
Code and dependency updates:
kvstore.Get()
Test completed
etcd
,etcd-setup-auth
(ephemeral container),cb-spider
andcb-mapui
cb-tumblebug
to test./scripts/init/genCredential.sh
./scripts/init/init.sh
Please let me know if you have any feedback, concerns, comments, enhancements and so on :-)