Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the missing vNet/subnets by the unexpected outside operations #1814

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yunkon-kim
Copy link
Member

@yunkon-kim yunkon-kim commented Sep 11, 2024

(related to #1808)

First of all, some parts in this PR need the next version of CB-Spider (so I opened this draft PR).
Since it's not urgent, I'm going to wait for the next release.

This PR includes the following updates:

  • Add RefineVNet() and RefineSubent(), which operates based on information managed by Tumblebug
  • Add actions (refine, force) on the following APIs
    • DELETE /ns/{nsId}/resources/vNet/{vNetId}?action=xxx
    • DELETE /ns/{nsId}/resources/vNet/{vNetId}/subnet/{subnetId}?action=xxx
  • Add the API to get subnet
    • GET /ns/{nsId}/resources/vNet/{vNetId}/subnet/{subnetId}
  • Improve comments in overall vNet/subnet functions and handlers

The following was considered for the "Refine" implementation:

  1. Assume that Tumblebug, Spider, and CSP have already lost the consistency of information.
  2. The information managed by Tumblebug is the most reliable.
  3. A mechanism that only logs warnings has been applied because various abnormal returns occurred.
    (Don't worry when you meet many warnings 😅)

* Add RefineVNet() and RefineSubent(), which operates based on information managed by Tumblebug
* Add actions (refine, force) on the following APIs
  - `DELETE /ns/{nsId}/resources/vNet/{vNetId}?action=xxx`
  - `DELETE /ns/{nsId}/resources/vNet/{vNetId}/subnet/{subnetId}?action=xxx`
* Add the API to get subnet
  - `GET /ns/{nsId}/resources/vNet/{vNetId}/subnet/{subnetId}`
* Improve comments in overall vNet/subnet functions and handlers
@yunkon-kim
Copy link
Member Author

@seokho-son (cc. @sykim-etri)

이 PR을 처리하기 위해서, Spider v0.9.5+이 필요합니다. Spider v0.9.5로 업그레이드해도 괜찮을지 문의 드립니다.

@seokho-son
Copy link
Member

@yunkon-kim (오프라인 디스커션 내용 로깅)

  • 현재 CB-Spider 메인테이너 @powerkimhub 님 요청에 따라, 향후 릴리스될 SP v0.9.6+ (CSP Tag 피쳐 적용 버전)을 적용하여 통합 및 테스트 진행 예정이었습니다.
  • 본 PR의 특징은 주로 CB-TB K8s 관리 기능 활용 중 예외적인 상황에서 처리를 지원하기 위한 기능이며, @sykim-etri 께서 시급한 기능은 아니라고 확인해주셨습니다.
  • 필요하다면 SP v0.9.5을 적용하여, 통합 작업을 진행해볼 수는 있으나, 본 PR의 처리 시급성이 높지 않고 SP v0.9.6+가 이번 주 내에 프리릴리스 예정이므로, 해당 버전 릴리스 이후에 PR을 처리하면 될 것 같습니다.
    • 이 경우, CB-TB 기존 기능 테스트, K8s 관리 기능 테스트, 네트워크 리소스 관련 기능 테스트 등이 병렬로 진행되어야 할 것으로 보임.
  • 이후 CB-TB 신규 버전(SP v0.9.6+ 을 활용하는)을 프리릴리스하는 순서가 되겠습니다. 참고하시기 바랍니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants