[WIP] Replace state resource with data source.

[jmcarp]

See:

• https://www.terraform.io/docs/configuration/data-sources.html
• https://www.terraform.io/docs/providers/terraform/d/remote_state.html

Goes with
cloud-gov/general-task#7.

@LinuxBozo

[jmcarp]

Note: this won't work yet because of a govcloud limitation. The issue has been handled in terraform in hashicorp/terraform#7999 should be able to use this once that change is released, hopefully in 0.7.2.

[LinuxBozo]

@jmcarp FYI: 0.7.3 has been released now.

[jmcarp]

@LinuxBozo: I updated this patch and cloud-gov/general-task#7 to work with terraform 0.7.3. I took a look at the output from terraform plan--a few default values have changed, but nothing that looks alarming. Diffs below. WDYT?

Staging / production:

- module.stack.terraform_remote_state.target_vpc

~ module.stack.bosh_user.bosh_user.aws_iam_user.iam_user
    force_destroy: "" => "false"

~ module.kubernetes.aws_elb.kubernetes_elb
    cross_zone_load_balancing: "false" => "true"

~ module.stack.vpc_peering.aws_vpc_peering_connection.peering
    accepter.#:  "" => "<computed>"
    requester.#: "" => "<computed>"

~ module.diego.aws_elb.diego_elb_main
    cross_zone_load_balancing: "false" => "true"

~ module.cf.aws_elb.cloudfoundry_elb_apps
    cross_zone_load_balancing: "false" => "true"

~ module.cf.aws_elb.cloudfoundry_elb_main
    cross_zone_load_balancing: "false" => "true"

~ module.cf.aws_elb.logsearch_elb
    cross_zone_load_balancing: "false" => "true"

~ module.cf.aws_elb.monitoring_elb
    cross_zone_load_balancing: "false" => "true"

~ module.cf.aws_subnet.az1_services
    tags.%:                 "2" => "1"
    tags.KubernetesCluster: "kubernetes-staging" => ""

~ module.cf.aws_subnet.az2_services
    tags.%:                 "2" => "1"
    tags.KubernetesCluster: "kubernetes-staging" => ""

Plan: 0 to add, 10 to change, 1 to destroy.

Tooling:

~ aws_elb.bosh_uaa_elb
    cross_zone_load_balancing: "false" => "true"

~ aws_elb.nessus_elb
    cross_zone_load_balancing: "false" => "true"

~ module.master_bosh_user.bosh_user.aws_iam_user.iam_user
    force_destroy: "" => "false"

~ module.cloudwatch_user.aws_iam_user.iam_user
    force_destroy: "" => "false"

~ module.aws_broker_user.aws_broker_user.aws_iam_user.iam_user
    force_destroy: "" => "false"

~ module.release_user.release_user.aws_iam_user.iam_user
    force_destroy: "" => "false"

~ module.ci_user.concourse_user.aws_iam_user.iam_user
    force_destroy: "" => "false"

~ module.tooling_bosh_user.bosh_user.aws_iam_user.iam_user
    force_destroy: "" => "false"

~ module.cf_user.cf_user.aws_iam_user.iam_user
    force_destroy: "" => "false"

~ module.s3_broker_user.s3_broker_user.aws_iam_user.iam_user
    force_destroy: "" => "false"

~ module.concourse_production.aws_elb.concourse_elb
    cross_zone_load_balancing: "false" => "true"

~ module.concourse_staging.aws_elb.concourse_elb
    cross_zone_load_balancing: "false" => "true"

Plan: 0 to add, 12 to change, 0 to destroy.

[LinuxBozo]

👍