Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove audit inputs list #269

Merged
merged 1 commit into from
Dec 19, 2023
Merged

remove audit inputs list #269

merged 1 commit into from
Dec 19, 2023

Conversation

markdboyd
Copy link
Contributor

Changes proposed in this pull request:

  • This list is unused according to @pburkholder, so removing it

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

This list is unused and out of date, so removing it improves clarity about our system

@markdboyd markdboyd requested a review from a team December 19, 2023 15:21
@pburkholder pburkholder merged commit 80223ce into main Dec 19, 2023
1 check passed
@markdboyd markdboyd deleted the remove-audit-inputs branch December 19, 2023 19:56
@markdboyd markdboyd mentioned this pull request Dec 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pburkholder pburkholder pburkholder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markdboyd @pburkholder