Add credentials that allow accessing state for external stack #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdboyd
reviewed
Sep 18, 2024
Comment on lines
+20
to
+22
| access_key = var.external_remote_state_reader_access_key_id | ||
| secret_key = var.external_remote_state_reader_secret_access_key | ||
| region = var.csb_aws_region_commercial |
There was a problem hiding this comment.
Why do we need these keys now if we didn't need them previously to read this remote state?
There was a problem hiding this comment.
There are two reasons:
- Based on my searches of
cg-provision, we don't currently access remote state from the external stack anywhere. Since this is the first time we're doing it, I needed to devise a method. - The state from the GovCloud partition is read without providing credentials — link for posterity — but we need explicit credentials to access to Commercial state.
There was a problem hiding this comment.
I didn't realize that this block was new as of ca8eff9. Makes sense now
There was a problem hiding this comment.
Ah, yep, sorry about that! This was missing & without it that commit doesn't work.
markdboyd
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
security considerations
Stores values in secret store and marks sensitive values as such.