Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: terraform destroy data-type and helm --set flag to pass secrets and multiple values. #128

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

h1manshu98
Copy link
Member

what

Terraform

  • data-type warning when setting destroy: true or false in caller file.
  • updated all conditions where inputs.destroy was used inside if statement for new boolean data-type

Helm

  • Updated set-parameter to pass secrets and multiple values
  • Added variable to uninstall helmchart
  • Added a message in rollback to show valid revision values.

@h1manshu98 h1manshu98 self-assigned this Mar 1, 2024
@h1manshu98 h1manshu98 added bug Something isn't working enhancement New feature or request labels Mar 1, 2024
Copy link
Member

@VishwajitNagulkar VishwajitNagulkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@AshutoshAM2002 AshutoshAM2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Tanveer143s Tanveer143s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@Tanveer143s Tanveer143s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clouddrove-ci clouddrove-ci merged commit ae37686 into master Mar 11, 2024
1 check passed
@clouddrove-ci clouddrove-ci deleted the fix/terraform-n-helm branch March 11, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants