Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added managedby and repository to dependencies. #23

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

K0smic
Copy link
Contributor

@K0smic K0smic commented Sep 23, 2024

What

  • Managedby and repository variables are passed to submodules, avoiding the creation of inconsistent tags.

Why

  • The module does not pass variables that have deafult values like managedby, this makes it impossible to pass them to submodules, at least with Terragrunt.

Considerations

I would avoid putting values in tags or names by default that are not strictly necessary for the service to work, or at least leave it up to the user to choose whether to use them with a boolean.

Copy link
Member

@nikitadugar nikitadugar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anmolnagpal anmolnagpal merged commit 5fe1f24 into clouddrove:master Sep 23, 2024
8 of 11 checks passed
@nikitadugar
Copy link
Member

@K0smic PR merged, new tag released https://github.com/clouddrove/terraform-aws-cognito/releases/tag/1.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants