Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump clouddrove/security-group/aws from 1.3.0 to 2.0.0 in /_example/complete-mysql #26

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 24, 2023

Bumps clouddrove/security-group/aws from 1.3.0 to 2.0.0.

Release notes

Sourced from clouddrove/security-group/aws's releases.

2.0.0

✨ New Features

🐛 Bug Fixes

Changelog

Sourced from clouddrove/security-group/aws's changelog.

[2.0.0] - 2023-07-18

✨ New Features

🐛 Bug Fixes

Commits
  • 1979c67 update README.md
  • d0aa119 Merge pull request #34 from clouddrove/issue-466
  • 7e98c4c feat: add prefix list id argument
  • 065e886 Merge pull request #33 from clouddrove/issue-466
  • 7e934bb feat: add prefix list id argument
  • 521e2ec feat: add prefix list id argument
  • 2730940 feat: add prefix list id argument
  • e78d969 feat: add prefix list id argument
  • 925ac6c feat: add prefix list id argument
  • ac15889 feat: added new resource and update module
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [clouddrove/security-group/aws](https://github.com/clouddrove/terraform-aws-security-group) from 1.3.0 to 2.0.0.
- [Release notes](https://github.com/clouddrove/terraform-aws-security-group/releases)
- [Changelog](https://github.com/clouddrove/terraform-aws-security-group/blob/master/CHANGELOG.md)
- [Commits](clouddrove/terraform-aws-security-group@1.3.0...2.0.0)

---
updated-dependencies:
- dependency-name: clouddrove/security-group/aws
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jul 24, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 24, 2023

Dependabot tried to add @approvers as a reviewer to this PR, but received the following error from GitHub:

POST https://api.github.com/repos/clouddrove/terraform-aws-mysql/pulls/26/requested_reviewers: 422 - Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the clouddrove/terraform-aws-mysql repository. // See: https://docs.github.com/rest/pulls/review-requests#request-reviewers-for-a-pull-request

@anmolnagpal
Copy link
Contributor

Terraform Security Scan Failed

Show Output
Result #1 MEDIUM Instance has very low backup retention period. 
────────────────────────────────────────────────────────────────────────────────
  main.tf:217
────────────────────────────────────────────────────────────────────────────────
  171    resource "aws_db_instance" "this" {
  ...  
  217  [   backup_retention_period = var.backup_retention_period (1)
  ...  
  240    }
────────────────────────────────────────────────────────────────────────────────
          ID aws-rds-specify-backup-retention
      Impact Potential loss of data and short opportunity for recovery
  Resolution Explicitly set the retention period to greater than the default

  More Information
  - https://aquasecurity.github.io/tfsec/latest/checks/aws/rds/specify-backup-retention/
  - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/rds_cluster#backup_retention_period
  - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/db_instance#backup_retention_period
────────────────────────────────────────────────────────────────────────────────


Result #2 MEDIUM Instance does not have Deletion Protection enabled 
────────────────────────────────────────────────────────────────────────────────
  main.tf:224
────────────────────────────────────────────────────────────────────────────────
  224      deletion_protection      = var.deletion_protection
────────────────────────────────────────────────────────────────────────────────
  Rego Package builtin.aws.rds.aws0177
     Rego Rule deny
────────────────────────────────────────────────────────────────────────────────


Result #3 LOW Instance does not have performance insights enabled. 
────────────────────────────────────────────────────────────────────────────────
  main.tf:214
────────────────────────────────────────────────────────────────────────────────
  171    resource "aws_db_instance" "this" {
  ...  
  214  [   performance_insights_enabled          = local.performance_insights_enabled (false)
  ...  
  240    }
────────────────────────────────────────────────────────────────────────────────
          ID aws-rds-enable-performance-insights
      Impact Without adequate monitoring, performance related issues may go unreported and potentially lead to compromise.
  Resolution Enable performance insights

  More Information
  - https://aquasecurity.github.io/tfsec/latest/checks/aws/rds/enable-performance-insights/
  - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/rds_cluster_instance#performance_insights_kms_key_id
  - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/db_instance#performance_insights_kms_key_id
────────────────────────────────────────────────────────────────────────────────


  timings
  ──────────────────────────────────────────
  disk i/o             99.502µs
  parsing              70.575507ms
  adaptation           137.001µs
  checks               13.295271ms
  total                84.107281ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    1
  blocks processed     82
  files read           3

  results
  ──────────────────────────────────────────
  passed               1
  ignored              2
  critical             0
  high                 0
  medium               2
  low                  1

  1 passed, 2 ignored, 3 potential problem(s) detected.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 24, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/terraform/_example/complete-mysql/clouddrove/security-group/aws-2.0.0 branch July 24, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants