Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added diagnostic setting resource for pe nic #5

Merged
merged 1 commit into from
Mar 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion _example/key-vault-with-access-policy/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ module "vault" {
"Restore",
"UnwrapKey",
"WrapKey",

"GetRotationPolicy"
]
certificate_permissions = [
"Get",
Expand Down
35 changes: 29 additions & 6 deletions main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -111,11 +111,11 @@ data "azurerm_private_endpoint_connection" "private-ip" {
depends_on = [azurerm_key_vault.key_vault]
}

data "azurerm_private_dns_zone" "example" {
count = var.enabled && var.enable_private_endpoint ? 1 : 0
name = local.private_dns_zone_name
resource_group_name = local.valid_rg_name
}
#data "azurerm_private_dns_zone" "example" {
# count = var.enabled && var.enable_private_endpoint ? 1 : 0
# name = local.private_dns_zone_name
# resource_group_name = local.valid_rg_name
#}

resource "azurerm_private_dns_zone" "dnszone" {
count = var.enabled && var.existing_private_dns_zone == null && var.enable_private_endpoint ? 1 : 0
Expand Down Expand Up @@ -181,7 +181,7 @@ resource "azurerm_role_assignment" "rbac_user_assigned" {
}

resource "azurerm_key_vault_key" "example" {
depends_on = [azurerm_key_vault.key_vault, azurerm_role_assignment.rbac_user_assigned]
depends_on = [azurerm_key_vault.key_vault, ]
count = var.enabled ? 1 : 0
name = format("mid-keyvault-%s", module.labels.id)
key_vault_id = join("", azurerm_key_vault.key_vault.*.id)
Expand Down Expand Up @@ -240,3 +240,26 @@ resource "azurerm_monitor_diagnostic_setting" "example" {
ignore_changes = [log_analytics_destination_type]
}
}

resource "azurerm_monitor_diagnostic_setting" "pe_kv_nic" {
depends_on = [azurerm_private_endpoint.pep]
count = var.enabled && var.diagnostic_setting_enable && var.enable_private_endpoint ? 1 : 0
name = format("%s-pe-kv-nic-diagnostic-log", module.labels.id)
target_resource_id = element(azurerm_private_endpoint.pep[count.index].network_interface.*.id, count.index)
storage_account_id = var.storage_account_id
eventhub_name = var.eventhub_name
eventhub_authorization_rule_id = var.eventhub_authorization_rule_id
log_analytics_workspace_id = var.log_analytics_workspace_id
log_analytics_destination_type = var.log_analytics_destination_type
metric {
category = "AllMetrics"
enabled = var.Metric_enable
retention_policy {
enabled = var.retention_policy_enabled
days = var.days
}
}
lifecycle {
ignore_changes = [log_analytics_destination_type]
}
}