DBT-703: Added tests for Iceberg v2 format #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vamshikolanu
requested changes
Jun 8, 2023
| check_result_nodes_by_name, | ||
| relation_from_name, | ||
| check_relation_types, | ||
| ) | ||
|
|
||
|
|
||
| def is_iceberg_table(project, tableName): |
There was a problem hiding this comment.
Can we add a function to make sure the created table is of format v2.
There was a problem hiding this comment.
The verification of table format-version is blocked by https://issues.apache.org/jira/browse/IMPALA-12209, as impala currently doesn't provide the format-version in the output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
To test the iceberg v2 table are supported, added tests for it.
Internal Jira ticket number or external issue link
https://jira.cloudera.com/browse/DBT-703
Testing procedure/screenshots(if appropriate):
https://gist.github.com/niteshy/62cecfbf4af78189f72980e49b7b2d9f
Checklist before requesting a review