Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBT-747: Stop support for views materialization in dbt-impala #184

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vamshikolanu
Copy link
Collaborator

@vamshikolanu vamshikolanu commented Oct 16, 2023

Describe your changes

Currently, there is no easy way to differentiate between tables and views in impala. The current query for list_relations_without_caching is not optimized; hence it started failing for larger number of tables.

Internal Jira ticket number or external issue link:

https://jira.cloudera.com/browse/DBT-747

Testing procedure/screenshots(if appropriate):

https://gist.github.com/vamshikolanu/e77a968cc7a9631390c2ed6f957f60c4

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have formatted my added/modified code to follow pep-8 standards
  • I have checked suggestions from python linter to make sure code is of good quality.

@amaralvieira
Copy link

I can only say that support for view materialization is a must. Removing it would only make this adapter unusable. 🙁

@kennycontreras
Copy link

Would it be better to implement a new argument/feature to skip the macro if needed instead of removing the whole code for the get_relation_type macro?
I agree with @amaralvieira

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants