DBT-747: Removing the describe table statement each tables rather use the show queries to gather metadata #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niteshy
changed the title
niteshy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
We have identified a bug where dbt-impala is trying to scan all schemas mentioned in dbt-project.yml and run a describe table on all tables of those schemas to figure out whether it's a view or a table that is causing large delays in the execution.
The problem was that Impala didn't implement the show views command which was fixed as part of https://issues.apache.org/jira/browse/IMPALA-3268.
Inorder to start using this adapter going further after this fix, we expect users to include this patch: https://issues.apache.org/jira/browse/IMPALA-3268
Internal Jira ticket number or external issue link
https://jira.cloudera.com/browse/DBT-747
Testing procedure/screenshots(if appropriate):
https://gist.github.com/vamshikolanu/977f79dc14acf16d512058410074718f
Checklist before requesting a review